Skip to content

Commit

Permalink
fix: move @types/npmlog to dependencies as node-logger is exporti…
Browse files Browse the repository at this point in the history
…ng `npmlog`

As `npmlog` is exported (`export { npmLog as instance };`), TS users of this lib need to have `npmlog` types too, so `@types/npmlog` have to be in `dependencies` and not `devDependencies`
  • Loading branch information
gaetanmaisse committed Jan 19, 2020
1 parent 4a5508d commit f96900c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion lib/node-logger/package.json
Expand Up @@ -27,14 +27,14 @@
"prepare": "node ../../scripts/prepare.js"
},
"dependencies": {
"@types/npmlog": "^4.1.2",
"chalk": "^3.0.0",
"core-js": "^3.0.1",
"npmlog": "^4.1.2",
"pretty-hrtime": "^1.0.3",
"regenerator-runtime": "^0.13.3"
},
"devDependencies": {
"@types/npmlog": "^4.1.1",
"@types/pretty-hrtime": "^1.0.0"
},
"publishConfig": {
Expand Down
2 changes: 1 addition & 1 deletion yarn.lock
Expand Up @@ -4333,7 +4333,7 @@
resolved "https://registry.yarnpkg.com/@types/normalize-package-data/-/normalize-package-data-2.4.0.tgz#e486d0d97396d79beedd0a6e33f4534ff6b4973e"
integrity sha512-f5j5b/Gf71L+dbqxIpQ4Z2WlmI/mPJ0fOkGGmFgtb6sAu97EPczzbS3/tJKxmcYDj55OX6ssqwDAWOHIYDRDGA==

"@types/npmlog@^4.1.1":
"@types/npmlog@^4.1.2":
version "4.1.2"
resolved "https://registry.yarnpkg.com/@types/npmlog/-/npmlog-4.1.2.tgz#d070fe6a6b78755d1092a3dc492d34c3d8f871c4"
integrity sha512-4QQmOF5KlwfxJ5IGXFIudkeLCdMABz03RcUXu+LCb24zmln8QW6aDjuGl4d4XPVLf2j+FnjelHTP7dvceAFbhA==
Expand Down

0 comments on commit f96900c

Please sign in to comment.