Skip to content

Commit

Permalink
Merge pull request #23077 from storybookjs/norbert/node-fetch-core-co…
Browse files Browse the repository at this point in the history
…mmon

Bug: Make core-common use node-fetch
(cherry picked from commit a4c2383)
  • Loading branch information
ndelangen authored and shilman committed Jun 17, 2023
1 parent ca2b714 commit ffed6a9
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 8 deletions.
2 changes: 2 additions & 0 deletions code/lib/core-common/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@
"@storybook/node-logger": "7.0.22",
"@storybook/types": "7.0.22",
"@types/node": "^16.0.0",
"@types/node-fetch": "^2.6.4",
"@types/pretty-hrtime": "^1.0.0",
"chalk": "^4.1.0",
"esbuild": "^0.17.0",
Expand All @@ -57,6 +58,7 @@
"glob-promise": "^6.0.2",
"handlebars": "^4.7.7",
"lazy-universal-dotenv": "^4.0.0",
"node-fetch": "^2.0.0",
"picomatch": "^2.3.0",
"pkg-dir": "^5.0.0",
"pretty-hrtime": "^1.0.3",
Expand Down
1 change: 1 addition & 0 deletions code/lib/core-common/src/utils/get-storybook-refs.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { readJSON } from 'fs-extra';
import { dirname, join } from 'path';
import findUp from 'find-up';
import fetch from 'node-fetch';

import resolveFrom from 'resolve-from';
import { logger } from '@storybook/node-logger';
Expand Down
18 changes: 10 additions & 8 deletions code/yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -5858,6 +5858,7 @@ __metadata:
"@storybook/types": 7.0.22
"@types/mock-fs": ^4.13.1
"@types/node": ^16.0.0
"@types/node-fetch": ^2.6.4
"@types/picomatch": ^2.3.0
"@types/pretty-hrtime": ^1.0.0
chalk: ^4.1.0
Expand All @@ -5871,6 +5872,7 @@ __metadata:
handlebars: ^4.7.7
lazy-universal-dotenv: ^4.0.0
mock-fs: ^5.2.0
node-fetch: ^2.0.0
picomatch: ^2.3.0
pkg-dir: ^5.0.0
pretty-hrtime: ^1.0.3
Expand Down Expand Up @@ -8224,13 +8226,13 @@ __metadata:
languageName: node
linkType: hard

"@types/node-fetch@npm:^2.5.7":
version: 2.6.3
resolution: "@types/node-fetch@npm:2.6.3"
"@types/node-fetch@npm:^2.5.7, @types/node-fetch@npm:^2.6.4":
version: 2.6.4
resolution: "@types/node-fetch@npm:2.6.4"
dependencies:
"@types/node": "*"
form-data: ^3.0.0
checksum: ce1a546d9a6f8df1c937f3c06ad85b57d92974a5feccc3502d13c0fc76c83629cd3f3f255dee03e5050abf90d0871f06628863ae758b70697af8b39cdd2e1c01
checksum: e43e4670ed8b7693dbf660ac1450b14fcfcdd8efca1eb0f501b6ad95af2d1fa06f8541db03e9511e82a5fee510a238fe0913330c9a58f8ac6892b985f6dd993e
languageName: node
linkType: hard

Expand Down Expand Up @@ -22833,17 +22835,17 @@ __metadata:
languageName: node
linkType: hard

"node-fetch@npm:^2.6.0, node-fetch@npm:^2.6.1, node-fetch@npm:^2.6.7":
version: 2.6.9
resolution: "node-fetch@npm:2.6.9"
"node-fetch@npm:^2.0.0, node-fetch@npm:^2.6.0, node-fetch@npm:^2.6.1, node-fetch@npm:^2.6.7":
version: 2.6.11
resolution: "node-fetch@npm:2.6.11"
dependencies:
whatwg-url: ^5.0.0
peerDependencies:
encoding: ^0.1.0
peerDependenciesMeta:
encoding:
optional: true
checksum: 7a4a0e027e509b741bec4172749103f158da23187ff251cb988dd54ea7267519c3fa11838971da0f5f3c54e79da3174e7bd72aa2179c9f69887511ece16c9c0f
checksum: 3ec847ca43f678d07b80abfd85bdf06523c2554ee9a494c992c5fc61f5d9cde9f9f16aa33ff09a62f19eee9d54813b8850d7f054cdfee8b2daf789c57f8eeaea
languageName: node
linkType: hard

Expand Down

0 comments on commit ffed6a9

Please sign in to comment.