Fix configurations/overview header & add glob info #10196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With some rewording for optimal conciseness and flow.
shilman
approved these changes
Mar 23, 2020
shilman
added
documentation
patch:yes
shilman
added a commit
that referenced
this pull request
Mar 31, 2020
Fix configurations/overview header & add glob info
shilman
added
the
patch:done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #10153
What I did
This is a documentation change.
glob.I went over the document and tried to improve the wording as much as I could. If you consider any of these changes to be regressions, then feel free to revert.
I decided to move the bottom section (about the relationship of main.js to Presets) to the top, because there was starting to be two sections for the same thing --- explaining main.js properties. And I chose to put this at the top, because people probably want to see that information most of the time.
How to test
Not sure --- how do you test these documentation changes?