Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace vue-docgen-loader with official one vue-simple-docgen-loader #11575

Closed
wants to merge 4 commits into from

Conversation

fernandopasik
Copy link
Member

Issue: #11291

vue-docgen-loader installed babel/register which caused error on typescript configs

What I did

Replace vue-docgen-loader with official one vue-simple-docgen-loader

How to test

  • Open storybook using vue

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with the changes in principle, but unfortunately the PR seems buggy. For example here's what I see on the InfoButton docs page in our vue-kitchen-sink example:

InfoButton_-_Simple_⋅_Storybook

@shilman shilman modified the milestones: 6.0 docs, 6.1 docs Jul 30, 2020
@fernandopasik
Copy link
Member Author

Sorry @shilman I thought it was straight forward. I'm trying to fix that

@fernandopasik
Copy link
Member Author

thanks to #11759 there's no need for this one anymore

@fernandopasik fernandopasik deleted the replace-vue-docgen-loader branch August 2, 2020 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants