Core: Fix support for main.ts/preview.ts files #11885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This is currently required to add support for typescript config files like maint.ts and preview.ts
yannbf
added
core
patch:yes
shilman
added
bug
and removed
patch:yes
shilman
added
the
patch:yes
shilman
approved these changes
Aug 11, 2020
shilman
changed the title
shilman
added
the
patch:done
shilman
added a commit
that referenced
this pull request
Aug 11, 2020
…support Core: Improve support for main.ts/preview.ts files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #11763
This is basically the same as #10099, for in depth information please check the description of that PR.
What I did
TLDR: @babel/register is a dependency of a few libs in the monorepo, and that's why the examples using
main.tswork. As soon as a user installs storybook in their projects, they don't have that dependency, which is required for server to be able to resolve ts files.How to test
1 - start a new storybook project with storybook 6 or just use
sb upgradein an existing project2 - run
yarn storybookand see it working fine.2 - rename main.js to main.ts
3 - run
yarn storybookand see it failing.4 - install
yarn add @babel/register -D5 - run
yarn storybookand see it working fine again.