Addon-docs: Fix ArgsTable regression #11889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
requested review from
aaronmcadam,
alexandrebodin,
alterx,
CodeByAlex,
dangreenisrael,
igor-dv,
jbovenschen,
kazupon,
leonrodenburg,
thani-sh,
ndelangen,
renaudtertrais,
saponifi3d,
stijnkoopal,
theinterned,
thomasbertet,
tmeasday,
usulpro and
z4o4z
as code owners
shilman
added
the
patch:yes
|
Self-merging @tmeasday |
shilman
added
the
patch:done
shilman
added a commit
that referenced
this pull request
Aug 11, 2020
Addon-docs: Fix ArgsTable regression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #11870
What I did
PR #11744 introduced a regression to
Props/ArgsTable. I changed thedefaultPropsbut did not update the rendering logic accordingly. Because we don't have good test coverage for theDocstab, the bug got through.This change:
defaultPropschangeHow to test
See the
Docs/mdxstories inofficial-storybookon theDocstab.