Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArgsTable: Error when subcomponents is an array #12033

Merged
merged 1 commit into from Aug 14, 2020
Merged

ArgsTable: Error when subcomponents is an array #12033

merged 1 commit into from Aug 14, 2020

Conversation

shilman
Copy link
Member

@shilman shilman commented Aug 14, 2020 •
edited

Issue: N/A

What I did

Show an error when user passes an array. Error gets displayed in DocsPage

How to test

See attached story

@shilman shilman requested a review from usulpro as a code owner August 14, 2020 18:07
@shilman shilman changed the title ArgsTable: Add warning when subcomponents is an array ArgsTable: Add error when subcomponents is an array Aug 14, 2020
@shilman shilman changed the title ArgsTable: Add error when subcomponents is an array ArgsTable: Error when subcomponents is an array Aug 14, 2020
@github-actions
Copy link
Contributor

Fails
🚫

PR is not labeled with one of: ["cleanup","doc-dependencies:update","BREAKING CHANGE","feature request","bug","documentation","maintenance","dependencies:update","dependencies","other"]

Generated by 🚫 dangerJS against 4b5f29b

@shilman shilman added block: argstable maintenance User-facing maintenance tasks labels Aug 14, 2020
@shilman shilman added this to the 6.0.x milestone Aug 14, 2020
@shilman
Copy link
Member Author

shilman commented Aug 14, 2020

self-merging @tmeasday

@shilman shilman merged commit 2786fb3 into next Aug 14, 2020
@monolithed
Copy link

Documentation is outdated.

@stof stof deleted the fix/argstable-subcomponents-warning branch May 25, 2022 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@usulpro usulpro Awaiting requested review from usulpro

Assignees
No one assigned
Labels
addon: docs block: argstable maintenance User-facing maintenance tasks
Projects
None yet
Milestone
6.0.x
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shilman @monolithed