Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move @types/webpack-env to devDependencies #12546

Closed
wants to merge 1 commit into from
Closed

Move @types/webpack-env to devDependencies #12546

wants to merge 1 commit into from

Conversation

sheepsteak
Copy link

Issue: @types/webpack-env is incorrectly in the dependencies of @storybook/react.

What I did

Moved to devDependencies

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@shilman
Copy link
Member

shilman commented Sep 25, 2020

@tooppaaa mind taking a quick look?

@shilman shilman added P3 and removed P3 labels Sep 25, 2020
@tooppaaa
Copy link
Contributor

Based on the description #9536
I think this should remain a dependency.

It's using in the ClientApi interface in app\react\src\client\preview\index.ts which is then exposed though functions.
@gaetanmaisse might be able to confirm :)

@gaetanmaisse
Copy link
Member

You're 💯 right @tooppaaa! The original issue about that is #7855.
@sheepsteak did you noticed any problem with the current setup? or were you just surprised to find @types/xxx in the dependencies part?

@sheepsteak
Copy link
Author

@sheepsteak did you noticed any problem with the current setup? or were you just surprised to find @types/xxx in the dependencies part?

I was just surprised and thought it was a mistake. No worries, I'll close this. Thanks for looking.

@sheepsteak sheepsteak closed this Sep 29, 2020
@sheepsteak sheepsteak deleted the react-dev-dep branch September 29, 2020 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks react typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants