Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Official-storybook: Fix ForwardRefButtonInnerPropTypes warning #12733

Merged
merged 3 commits into from
Jan 15, 2022

Conversation

andezzat
Copy link
Member

@andezzat andezzat commented Oct 10, 2020

Issue: React Warning

What I did

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@shilman shilman changed the title fix(official-storybook): remove ForwardRefButtonInnerPropTypes warning Official-storybook: Fix ForwardRefButtonInnerPropTypes warning Oct 11, 2020
@shilman shilman added the maintenance User-facing maintenance tasks label Oct 11, 2020
@stale
Copy link

stale bot commented Dec 25, 2020

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Dec 25, 2020
@darleendenno darleendenno self-assigned this Jul 12, 2021
@stale stale bot removed the inactive label Jul 12, 2021
Copy link
Contributor

@darleendenno darleendenno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @andezzat !!! This looks great! We can even see props in the controls panel 🎉

Let's get this current with next and we'll be good to go 👍

@darleendenno
Copy link
Contributor

@shilman I'm having difficulty getting this updated with next -- want to give it a shot? You can accept incoming changes to resolve conflicts

@andezzat andezzat removed their assignment Jul 19, 2021
@nx-cloud
Copy link

nx-cloud bot commented Jul 21, 2021

☁️ Nx Cloud Report

CI ran the following commands for commit fd42ebb. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@shilman
Copy link
Member

shilman commented Jul 21, 2021

@darleendenno done ✅

@shilman shilman added this to the 6.4 PRs milestone Jul 22, 2021
@darleendenno darleendenno removed their assignment Sep 23, 2021
@stale
Copy link

stale bot commented Jan 9, 2022

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Jan 9, 2022
@stale stale bot removed the inactive label Jan 15, 2022
@shilman shilman self-assigned this Jan 15, 2022
@shilman shilman merged commit 1593f12 into storybookjs:next Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants