Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React: Add strictMode option #12781

Merged
merged 6 commits into from Oct 16, 2020
Merged

React: Add strictMode option #12781

merged 6 commits into from Oct 16, 2020

Conversation

tooppaaa
Copy link
Contributor

Issue: #12734

What I did

Add strictMode option

How to test

  • Official Storybook

@shilman shilman added feature request and removed maintenance User-facing maintenance tasks labels Oct 15, 2020
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change for backwards compatibility

app/react/src/client/preview/render.tsx Outdated Show resolved Hide resolved
@shilman shilman added this to the 6.1 core milestone Oct 15, 2020
@shilman
Copy link
Member

shilman commented Oct 16, 2020

@tooppaaa @tmeasday merging even tho we don't really understand the render count issue. can address in a followup

@shilman shilman merged commit 2b9ff49 into next Oct 16, 2020
@shilman shilman deleted the feature/reactStrictModeOption branch October 16, 2020 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants