CLI: Add core-js to Preact generator #13138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MunsMan
requested review from
ndelangen,
shilman and
stijnkoopal
as code owners
|
Shouldn't be needed once #13055 is merged |
shilman
changed the title
shilman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #13104
What I did
I added core-js to the generator of preact, which solved the problem I had.
How to test
I did not test that, because I didn't knew how.
This PR is linked to the following Issue: #13104
I used the following example: ANGULAR fix
@shilman Sorry I not experienced enough to Test such a bit application. I need some guidance for that.