Core: Clear manager cache on runtime error #13230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghengeveld
requested review from
alterx,
igor-dv and
tmeasday
as code owners
ghengeveld
changed the title
This was referenced Nov 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues: #13199 #13209
What I did
This reports back any runtime (console) errors from the browser to the dev server, and clears the manager cache if there's a runtime error originating from the manager UI.
This also includes some smaller tweaks and fixes, including one for the
TypeError: Cannot read property 'publicPath' of undefinederror reported in #13209.How to test
Run
start-storybookto make sure the manager UI is cached. Then throw an error at the end ofmanager.jsand restart Storybook. Note that it will used the cached manager and therefore is not broken. Now start again with--no-manager-cache. Note that the UI is now broken (white screen) with a runtime error in the browser console. Also note that the CLI will now show the browser error in your terminal. Finally,start-storybookagain without the--no-manager-cacheflag, so it'll build cache. Then exit and run it again. Note it will not have a cached manager this time, because it got cleared when the runtime error occurred.If your answer is yes to any of these, please make sure to include it in your PR.