Yarn2: Use `workspace:*` versions #15413

shilman · 2021-06-29T11:45:38Z

What I did

Use workspace:* version, for details see: https://yarnpkg.com/features/workspaces#workspace-ranges-workspace
Use Yarn workspaces related stuff to power build NPM script
Remove all usages of Lerna

--

Commands for the release:

# Record the requested upgrade in `.yarn/versions/xxx`
yarn workspaces foreach --all version prerelease --deferred

# Apply the version upgrades to all packages (also update version of peer deps on local packages)
yarn version apply --all

# Release the Kraken
yarn workspaces foreach --parallel --no-private npm publish 

## Pack
# yarn workspaces foreach --parallel --no-private pack

nx-cloud · 2021-06-29T11:47:16Z

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 3fc8bdd. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

🟥 Failed Commands
`nx run-many --target=prepare --all --parallel=2 --max-parallel=15 -- --optimized`

Sent with 💌 from NxCloud.

addons/docs/package.json

addons/toolbars/package.json

.yarnrc.yml

lib/core/package.json

scripts/run-registry.ts

hydrosquall · 2021-07-16T16:21:12Z

One thing to keep an eye out after this change is that several lerna commands don't work if workspace:* versions are used. I noticed this while setting up auto in a monorepo. This may be a non issue if you're using nx / other tools to manage the repo.

lerna/lerna#2564

However, there is an in-progress PR adding this: lerna/lerna#2450

gaetanmaisse · 2021-07-16T16:56:51Z

@hydrosquall You're 💯 true and some of the changes in this PR are replacements of Lerna commands by Yarn 2 ones or simplification in the scripts. I still need to figure out how to make our build script working again and I guess Lerna won't be used anywhere.

Also, we have a strange behavior running yarn workspaces foreach -all version prerelease --deferred, everything is ok on my machine but on @shilman's one it just stops after updating the version for the root package 🤔 I think I will need to discuss with @merceyz to see what I'm doing wrong

merceyz · 2021-07-16T17:48:38Z

it just stops after updating the version for the root package 🤔 I think I will need to discuss with @merceyz to see what I'm doing wrong

Fixed in yarnpkg/berry#2255 / 3.0.0-rc.1

yarn set version 3.0.0-rc.9 && yarn plugin import constraints && yarn plugin import version && yarn plugin import workspace-tools && yarn plugin import typescript

gaetanmaisse · 2021-07-16T19:24:24Z

Thanks @merceyz! I was staying on Yarn 2.4.2 because of some issues with portal: protocol (like the react@null issue we discussed on Discord), I'm on holiday for a few more days, I'll try again the 3.0.0-rc.9 when I get back 😉

addons/docs/src/frameworks/vue3/prepareForInline.ts

merceyz · 2021-08-03T20:59:56Z

package.json

-    "dev:tsc": "lerna exec --scope \"@storybook/*\" --parallel -- cross-env-shell node \\$LERNA_ROOT_PATH/scripts/utils/watch-tsc.js",
+    "dev": "echo \"This command is deprecated and will be removed soon, please use `yarn build` instead\"",
+    "dev:babel": "echo \"This command is deprecated and will be removed soon, please use `yarn build` instead\"",
+    "dev:tsc": "echo \"This command is deprecated and will be removed soon, please use `yarn build` instead\"",
    "github-release": "github-release-from-changelog",
    "lint": "yarn lint:js . && yarn lint:md .",
    "lint:js": "cross-env NODE_ENV=production eslint --cache --cache-location=.cache/eslint --ext .js,.jsx,.json,.html,.ts,.tsx,.mjs --report-unused-disable-directives",


Suggested change

"lint:js": "cross-env NODE_ENV=production eslint --cache --cache-location=.cache/eslint --ext .js,.jsx,.json,.html,.ts,.tsx,.mjs --report-unused-disable-directives",

"lint:js": "NODE_ENV=production eslint --cache --cache-location=.cache/eslint --ext .js,.jsx,.json,.html,.ts,.tsx,.mjs --report-unused-disable-directives",

You can remove cross-env since Yarn has its own portable shell

Neat! I will take a look at all cross-env usages across the monorepo

gaetanmaisse · 2021-08-03T21:11:32Z

@shilman I think we will be able to give one more try to the updated release process 😄

shilman · 2021-08-04T03:13:14Z

@gaetanmaisse my forehead's almost healed from the last time we tried to do anything together 🤕 so just let me know whenever is good for you 😂

…r workspaces To check the constraint just run `yarn constraints`

arcanis · 2021-10-26T09:30:28Z

Quick note: we now support workspace:^ which does the same as workspace:*, except that on publish Yarn will turn it into ^x.y.z rather than x.y.z (with x.y.z being the true version).

stale · 2022-01-09T03:17:01Z

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

# Conflicts: # .yarn/releases/yarn-sources.cjs # .yarnrc.yml # addons/a11y/package.json # addons/actions/package.json # addons/backgrounds/package.json # addons/controls/package.json # addons/docs/package.json # addons/essentials/package.json # addons/jest/package.json # addons/links/package.json # addons/measure/package.json # addons/outline/package.json # addons/storyshots/storyshots-core/package.json # addons/storyshots/storyshots-puppeteer/package.json # addons/storysource/package.json # addons/toolbars/package.json # addons/viewport/package.json # app/angular/package.json # app/ember/package.json # app/html/package.json # app/preact/package.json # app/react/package.json # app/server/package.json # app/svelte/package.json # app/vue/package.json # app/vue3/package.json # app/web-components/package.json # docs/versions/next.json # examples/angular-cli/package.json # examples/cra-kitchen-sink/package.json # examples/cra-react15/package.json # examples/cra-ts-essentials/package.json # examples/cra-ts-kitchen-sink/package.json # examples/ember-cli/package.json # examples/html-kitchen-sink/package.json # examples/official-storybook/package.json # examples/preact-kitchen-sink/package.json # examples/react-ts-webpack4/package.json # examples/react-ts/package.json # examples/server-kitchen-sink/package.json # examples/standalone-preview/package.json # examples/svelte-kitchen-sink/package.json # examples/vue-3-cli/package.json # examples/vue-cli/package.json # examples/vue-kitchen-sink/package.json # examples/web-components-kitchen-sink/yarn.lock # lerna.json # lib/addons/package.json # lib/api/package.json # lib/builder-webpack4/package.json # lib/builder-webpack5/package.json # lib/channel-postmessage/package.json # lib/channel-websocket/package.json # lib/cli-sb/package.json # lib/cli-storybook/package.json # lib/cli/package.json # lib/client-api/package.json # lib/codemod/package.json # lib/components/package.json # lib/core-client/package.json # lib/core-common/package.json # lib/core-server/package.json # lib/core/package.json # lib/manager-webpack4/package.json # lib/manager-webpack5/package.json # lib/router/package.json # lib/source-loader/package.json # lib/theming/package.json # lib/ui/package.json # package.json # scripts/build-package.js # scripts/run-registry.ts # yarn.lock

ndelangen · 2022-06-30T22:21:31Z

@shilman @gaetanmaisse @merceyz I did my best to get this updated with next but... it wasn't easy, and I'm 100000% sure stuff is broken now.

What the course of action here? Are we proceeding? Are we taking this and redo-ing it on future/base? Are we abandoning this approach?

Let's make this PR a draft, and discuss if it's salvageable?

ndelangen · 2022-06-30T22:23:31Z

Also ping-ing @arcanis And @hydrosquall ☝️

Can you tell me what the roadmap is for this PR?

gaetanmaisse · 2022-07-01T06:54:30Z

I also tried to update it a few weeks ago, a nightmare and at the end it wasn't working anymore.

What the course of action here? Are we proceeding? Are we taking this and redo-ing it on future/base? Are we abandoning this approach?

I've in mind to try to redo it on future/base, but maybe it makes more sense to deal with the examples first? wdyt @ndelangen

ghiscoding · 2022-07-12T15:34:01Z

@shilman and everyone else, you could finish this PR by switching to Lerna-Lite which did add support to workspace: protocol. I created the Lerna-Lite fork, when Lerna was largely unsupported, and I also recently switched the project itself to pnpm with workspace: protocol and everything is working great. So if you want to complete this PR, just switch to Lerna-Lite 😉

shilman changed the title ~~Yarn: Use workspace:* versions~~ Yarn2: Use workspace:* versions Jun 29, 2021

gaetanmaisse reviewed Jun 29, 2021

View reviewed changes

addons/docs/package.json Show resolved Hide resolved

addons/docs/package.json Outdated Show resolved Hide resolved

addons/toolbars/package.json Show resolved Hide resolved

merceyz reviewed Jun 29, 2021

View reviewed changes

.yarnrc.yml Outdated Show resolved Hide resolved

gaetanmaisse added the maintenance User-facing maintenance tasks label Jul 8, 2021

gaetanmaisse reviewed Jul 9, 2021

View reviewed changes

lib/core/package.json Outdated Show resolved Hide resolved

merceyz reviewed Jul 9, 2021

View reviewed changes

scripts/run-registry.ts Outdated Show resolved Hide resolved

gaetanmaisse force-pushed the refine-yarn-usage branch 3 times, most recently from 6ee1036 to 235adae Compare August 3, 2021 20:34

merceyz reviewed Aug 3, 2021

View reviewed changes

addons/docs/src/frameworks/vue3/prepareForInline.ts Outdated Show resolved Hide resolved

merceyz reviewed Aug 3, 2021

View reviewed changes

gaetanmaisse force-pushed the refine-yarn-usage branch from 544a16a to b39e844 Compare August 3, 2021 21:10

gaetanmaisse and others added 8 commits August 9, 2021 11:23

chore: add Yarn Constraint Plugin

132844e

chore: define a constraint to enforce use of workspace:* version fo…

d44dff9

…r workspaces To check the constraint just run `yarn constraints`

chore: use workspace:* version range

35ce871

chore: add version & workspace-tools yarn2 plugins

09eac65

chore: use Yarn instead of lerna to publish the packages to verdaccio

73d80a3

chore: update Yarn to the latest master version

ae608dd

chore: replace lerna by Yarn in prepare and build commands

6d64a7e

chore: remove everything related to lerna

a965266

gaetanmaisse force-pushed the refine-yarn-usage branch from b39e844 to a965266 Compare August 9, 2021 09:34

gaetanmaisse marked this pull request as ready for review August 9, 2021 09:59

Merge branch 'next' into refine-yarn-usage

5450252

brianespinosa mentioned this pull request Aug 12, 2021

feat: Support the workspace: protocol lerna/lerna#2450

Closed

9 tasks

merceyz mentioned this pull request Sep 3, 2021

Adds support for workspace:^ in peerDependencies yarnpkg/berry#3386

Merged

3 tasks

chentsulin mentioned this pull request Oct 4, 2021

yarn v3 bottenderjs/messaging-apis#601

Closed

shilman assigned shilman and gaetanmaisse Nov 1, 2021

ja0nz mentioned this pull request Nov 14, 2021

Feature/yarn3 - migrate to the new version of yarn thi-ng/umbrella#326

Merged

stale bot added the inactive label Jan 9, 2022

stale bot removed the inactive label Jun 30, 2022

ndelangen marked this pull request as draft June 30, 2022 22:21

ndelangen closed this Oct 5, 2022

charlie-yao mentioned this pull request Oct 5, 2022

Improve versioning/release/etc. process charlie-yao/react-aria-widgets#87

Open

kasperpeulen deleted the refine-yarn-usage branch November 16, 2022 08:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Yarn2: Use `workspace:*` versions #15413

Yarn2: Use `workspace:*` versions #15413

shilman commented Jun 29, 2021 •

edited by gaetanmaisse

nx-cloud bot commented Jun 29, 2021 •

edited

hydrosquall commented Jul 16, 2021

gaetanmaisse commented Jul 16, 2021 •

edited

merceyz commented Jul 16, 2021 •

edited

gaetanmaisse commented Jul 16, 2021

merceyz Aug 3, 2021

gaetanmaisse Aug 3, 2021

gaetanmaisse commented Aug 3, 2021

shilman commented Aug 4, 2021 •

edited

arcanis commented Oct 26, 2021

stale bot commented Jan 9, 2022

ndelangen commented Jun 30, 2022

ndelangen commented Jun 30, 2022

gaetanmaisse commented Jul 1, 2022

ghiscoding commented Jul 12, 2022

	"lint:js": "cross-env NODE_ENV=production eslint --cache --cache-location=.cache/eslint --ext .js,.jsx,.json,.html,.ts,.tsx,.mjs --report-unused-disable-directives",
	"lint:js": "NODE_ENV=production eslint --cache --cache-location=.cache/eslint --ext .js,.jsx,.json,.html,.ts,.tsx,.mjs --report-unused-disable-directives",

Yarn2: Use workspace:* versions #15413

Yarn2: Use workspace:* versions #15413

Conversation

shilman commented Jun 29, 2021 • edited by gaetanmaisse

What I did

nx-cloud bot commented Jun 29, 2021 • edited

☁️ Nx Cloud Report

hydrosquall commented Jul 16, 2021

gaetanmaisse commented Jul 16, 2021 • edited

merceyz commented Jul 16, 2021 • edited

gaetanmaisse commented Jul 16, 2021

merceyz Aug 3, 2021

Choose a reason for hiding this comment

gaetanmaisse Aug 3, 2021

Choose a reason for hiding this comment

gaetanmaisse commented Aug 3, 2021

shilman commented Aug 4, 2021 • edited

arcanis commented Oct 26, 2021

stale bot commented Jan 9, 2022

ndelangen commented Jun 30, 2022

ndelangen commented Jun 30, 2022

gaetanmaisse commented Jul 1, 2022

ghiscoding commented Jul 12, 2022

Yarn2: Use `workspace:*` versions #15413

Yarn2: Use `workspace:*` versions #15413

shilman commented Jun 29, 2021 •

edited by gaetanmaisse

nx-cloud bot commented Jun 29, 2021 •

edited

gaetanmaisse commented Jul 16, 2021 •

edited

merceyz commented Jul 16, 2021 •

edited

shilman commented Aug 4, 2021 •

edited