Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Add webpack5 builder to CRA5 sb init #16194

Merged
merged 5 commits into from
Oct 1, 2021
Merged

CLI: Add webpack5 builder to CRA5 sb init #16194

merged 5 commits into from
Oct 1, 2021

Conversation

shilman
Copy link
Member

@shilman shilman commented Sep 29, 2021

Issue: #16150

What I did

  • Install webpack5 builder on fresh CRA projects
  • Version @storybook/preset-create-react-app based on CRA version?

How to test

yarn create react-app --scripts-version=@next --template=cra-template@next cra-sb-fresh
cd cra-sb-fresh
/path/to/storybook/lib/cli/bin/index.js init

Sorry, something went wrong.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@shilman shilman added cli maintenance User-facing maintenance tasks patch:yes Bugfix & documentation PR that need to be picked to main branch labels Sep 29, 2021
@nx-cloud
Copy link

nx-cloud bot commented Sep 29, 2021

Nx Cloud Report

CI ran the following commands for commit 155a184. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

@shilman shilman requested review from mrmckeb and kylegach September 29, 2021 18:52
Copy link
Contributor

@kylegach kylegach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks (and works) great!

@shilman shilman merged commit ece2504 into next Oct 1, 2021
@shilman shilman deleted the 16150-cra5-sb-init branch October 1, 2021 15:06
@shilman shilman mentioned this pull request Oct 1, 2021
3 tasks
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Oct 1, 2021
shilman added a commit that referenced this pull request Oct 1, 2021
CLI: Add webpack5 builder to CRA5 `sb init`
@shilman shilman added this to the 6.4 PRs milestone Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli maintenance User-facing maintenance tasks patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants