Core: Fix packageName check in build-dev #16823
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current check breaks for non-storybook packages. `Array.split` always returns 1 items at minimum, so with a `> 0` check in there it always executed the "if" part, breaking on the `.split()[1]` after.
Nx Cloud ReportCI ran the following commands for commit bfb942b. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
shilman
added
maintenance
shilman
changed the title
|
@shilman – I just ran into this issue when updating versions in @glimmerx/storybook. When can we expect this fix to be published? |
|
@tarinrickett will publish today |
shilman
added
patch:yes
shilman
added a commit
that referenced
this pull request
Nov 30, 2021
Core: Fix packageName check in build-dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current check breaks for non-storybook packages.
Array.splitalways returns 1 items at minimum, so with a> 0check in there it always executed the "if" part, breaking on the.split()[1]after.What I did
Change to a
> 1check to allow accessing the 2nd item in the Array.How to test
I guess there is no non-storybook packaged framework included in the kitchen sink or other tests, otherwise this would have failed already.
At minimum, all existing test should still pass with this change.