-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angular: Add back-compat method to find options (styles) in angular.json #16832
Conversation
Nx Cloud ReportCI ran the following commands for commit 96e28cf. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
8925741
to
c637bde
Compare
… a fix structure of angular.json
c637bde
to
49ef868
Compare
logger.info(`=> TODO ~ legacy way to get default options`); | ||
logger.info(`=> TODO ~ Add deprecation warning and ex for builder use ? `); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets remove those and merge the PR to hotfix the current issue and improve the situation afterwards
logger.info(`=> TODO ~ legacy way to get default options`); | |
logger.info(`=> TODO ~ Add deprecation warning and ex for builder use ? `); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo here: "and wild be removed on Storybook 7.0"
Only matters if you're going to create the docs based on that
I tested it in my project that had this issue and it fixed it. Everything works as expected |
@ThibaudAV @kroeder I did a little cleanup on the file and will merge/release an a 6.5 alpha. Once we get a few people testing it successfully we can patch the change back to 6.4. Sorry for meddling here but I feel this is time sensitive since people are upgrading to 6.4 now. 🙈 |
…find-options Angular: Add back-compat method to find options (styles) in angular.json
Ok I will add the message of deprecation of this code for v7 and the info in the MIGRATION.md in another PR |
TODO
Issue:
What I did
How to test
If your answer is yes to any of these, please make sure to include it in your PR.