Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-docs: Fix transclusion crash on webpack rules without test field #16873

Merged
merged 1 commit into from
Dec 2, 2021

Conversation

shilman
Copy link
Member

@shilman shilman commented Dec 2, 2021

Issue: N/A

#11334 followup

What I did

Guard against empty rule.test

self-merging @tmeasday

How to test

N/A

@shilman shilman added bug patch:yes Bugfix & documentation PR that need to be picked to main branch addon: docs labels Dec 2, 2021
@nx-cloud
Copy link

nx-cloud bot commented Dec 2, 2021

Nx Cloud Report

CI ran the following commands for commit 04fe3b3. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

@shilman shilman merged commit 6faa6be into next Dec 2, 2021
@shilman shilman deleted the 11334-addon-docs-transclusion-fix branch December 2, 2021 15:39
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Dec 3, 2021
shilman added a commit that referenced this pull request Dec 3, 2021
…ion-fix

Addon-docs: Fix transclusion crash on webpack rules without test field
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: docs bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant