Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Be explicit about viewMode to fix Vue issue #16919

Merged
merged 1 commit into from
Dec 6, 2021
Merged

Core: Be explicit about viewMode to fix Vue issue #16919

merged 1 commit into from
Dec 6, 2021

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Dec 6, 2021 •
edited

Issue: #16862

What I did

Explicitly pass viewMode into renderStoryToElement, instead of trying to infer it from the canvasElement.

Vue is doing whacky (?) things and re-creating the #root element, but in any case, it is better to just be explicit I think.

How to test

  • Is this testable with Jest or Chromatic screenshots?

Try changing globals in the vue-cli example. Also the E2E tests

@tmeasday
Explicitly pass viewMode into renderStoryToElement
c2b7147 
Instead of trying to infer it from the `canvasElement`.

Vue is doing whacky things and re-creating the `#root` element, but in any case, it is better to just be explicit I think.
@tmeasday tmeasday requested a review from shilman December 6, 2021 11:37
@tmeasday tmeasday mentioned this pull request Dec 6, 2021
Closed
2 tasks
@nx-cloud
Copy link

nx-cloud bot commented Dec 6, 2021 •
edited

Nx Cloud Report

CI ran the following commands for commit c2b7147. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

gaetanmaisse
gaetanmaisse approved these changes Dec 6, 2021
View reviewed changes
Copy link
Member

@gaetanmaisse gaetanmaisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪🏻

@shilman shilman changed the title Be explicit about viewMode to fix Vue issue Core: Be explicit about viewMode to fix Vue issue Dec 6, 2021
@shilman shilman added the core label Dec 6, 2021
@shilman shilman merged commit 5543a7e into next Dec 6, 2021
@shilman shilman deleted the 16862-fix-vue-rerender-viewMode branch December 6, 2021 12:36
@shilman shilman added patch:yes Bugfix & documentation PR that need to be picked to main branch patch:done Patch/release PRs already cherry-picked to main/release branch labels Dec 6, 2021
shilman added a commit that referenced this pull request Dec 9, 2021
@shilman
Merge pull request #16919 from storybookjs/16862-fix-vue-rerender-vie…
d2a76fa 
…wMode

Core: Be explicit about `viewMode` to fix Vue issue
@shilman shilman mentioned this pull request Dec 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaetanmaisse gaetanmaisse gaetanmaisse approved these changes

@shilman shilman Awaiting requested review from shilman

Assignees
No one assigned
Labels
bug core patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch vue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tmeasday @gaetanmaisse @shilman