Angular: Fix support for non-roman alphabets in story titles #16931
+64
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #15147
What I did
@storybook/angular uses story id as HTML tag. So using non-ascii characters in story title generates invalid HTML tag. I added a new method to create a valid HTML tag from story id. This method returns storyId when it doesn't contain any non-ASCII alphanumerics. Otherwise, it generates an HTML tag from storyId by removing non-ASCII alphanumerics from storyId, prefixing "sb-", and suffixing "-component"
How to test
My answer is no to all of these questions. I added tests in
app/angular/src/client/preview/angular-beta/RendererFactory.test.ts
to test having non-ascii characters in story id doesn't break stories now.