Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React: Remove react-dev-utils #17022

Merged
merged 3 commits into from Jan 3, 2022
Merged

React: Remove react-dev-utils #17022

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
55247e1
remove react-dev-utils
Taillook Dec 15, 2021
8c1c10f
`yarn test -u`
Taillook Dec 15, 2021
62ecebb
Merge branch 'next' into pr/17022
shilman Jan 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion app/react/package.json
View file
Open in desktop
Expand Up @@ -66,7 +66,6 @@
"global": "^4.4.0",
"lodash": "^4.17.21",
"prop-types": "^15.7.2",
"react-dev-utils": "^11.0.4",
"react-refresh": "^0.11.0",
"read-pkg-up": "^7.0.1",
"regenerator-runtime": "^0.13.7",
Expand Down
2 changes: 0 additions & 2 deletions lib/builder-webpack4/package.json
View file
Open in desktop
Expand Up @@ -98,7 +98,6 @@
"postcss-flexbugs-fixes": "^4.2.1",
"postcss-loader": "^4.2.0",
"raw-loader": "^4.0.2",
"react-dev-utils": "^11.0.4",
"stable": "^0.1.8",
"style-loader": "^1.3.0",
"terser-webpack-plugin": "^4.2.3",
Expand All @@ -113,7 +112,6 @@
},
"devDependencies": {
"@types/case-sensitive-paths-webpack-plugin": "^2.1.4",
"@types/react-dev-utils": "^9.0.4",
"@types/terser-webpack-plugin": "^5.0.2",
"@types/webpack-dev-middleware": "^3.7.3",
"@types/webpack-hot-middleware": "^2.25.3",
Expand Down
3 changes: 0 additions & 3 deletions lib/builder-webpack4/src/preview/iframe-webpack.config.ts
View file
Open in desktop
Expand Up @@ -4,7 +4,6 @@ import { DefinePlugin, HotModuleReplacementPlugin, ProgressPlugin } from 'webpac
import type { Configuration, RuleSetRule } from '@types/webpack';
import HtmlWebpackPlugin from 'html-webpack-plugin';
import CaseSensitivePathsPlugin from 'case-sensitive-paths-webpack-plugin';
import WatchMissingNodeModulesPlugin from 'react-dev-utils/WatchMissingNodeModulesPlugin';
import TerserWebpackPlugin from 'terser-webpack-plugin';
import VirtualModulePlugin from 'webpack-virtual-modules';
import PnpWebpackPlugin from 'pnp-webpack-plugin';
Expand All @@ -19,7 +18,6 @@ import {
es6Transpiler,
handlebars,
interpolate,
nodeModulesPaths,
Options,
toImportFn,
normalizeStories,
Expand Down Expand Up @@ -212,7 +210,6 @@ export default async (options: Options & Record<string, any>): Promise<Configura
...stringifyProcessEnvs(envs),
NODE_ENV: JSON.stringify(envs.NODE_ENV),
}),
isProd ? null : new WatchMissingNodeModulesPlugin(nodeModulesPaths),
isProd ? null : new HotModuleReplacementPlugin(),
new CaseSensitivePathsPlugin(),
quiet ? null : new ProgressPlugin({}),
Expand Down
2 changes: 0 additions & 2 deletions lib/builder-webpack5/package.json
View file
Open in desktop
Expand Up @@ -87,7 +87,6 @@
"glob-promise": "^3.4.0",
"html-webpack-plugin": "^5.0.0",
"path-browserify": "^1.0.1",
"react-dev-utils": "^11.0.4",
"stable": "^0.1.8",
"style-loader": "^2.0.0",
"terser-webpack-plugin": "^5.0.3",
Expand All @@ -100,7 +99,6 @@
},
"devDependencies": {
"@types/case-sensitive-paths-webpack-plugin": "^2.1.4",
"@types/react-dev-utils": "^9.0.4",
"@types/terser-webpack-plugin": "^5.0.2",
"@types/webpack-dev-middleware": "^4.1.0",
"@types/webpack-hot-middleware": "^2.25.3",
Expand Down
3 changes: 0 additions & 3 deletions lib/builder-webpack5/src/preview/iframe-webpack.config.ts
View file
Open in desktop
Expand Up @@ -8,7 +8,6 @@ import {
} from 'webpack';
import HtmlWebpackPlugin from 'html-webpack-plugin';
import CaseSensitivePathsPlugin from 'case-sensitive-paths-webpack-plugin';
import WatchMissingNodeModulesPlugin from 'react-dev-utils/WatchMissingNodeModulesPlugin';
import TerserWebpackPlugin from 'terser-webpack-plugin';
import VirtualModulePlugin from 'webpack-virtual-modules';
import ForkTsCheckerWebpackPlugin from 'fork-ts-checker-webpack-plugin';
Expand All @@ -19,7 +18,6 @@ import {
toRequireContextString,
es6Transpiler,
stringifyProcessEnvs,
nodeModulesPaths,
handlebars,
interpolate,
Options,
Expand Down Expand Up @@ -217,7 +215,6 @@ export default async (options: Options & Record<string, any>): Promise<Configura
NODE_ENV: JSON.stringify(process.env.NODE_ENV),
}),
new ProvidePlugin({ process: 'process/browser.js' }),
isProd ? null : new WatchMissingNodeModulesPlugin(nodeModulesPaths),
isProd ? null : new HotModuleReplacementPlugin(),
new CaseSensitivePathsPlugin(),
quiet ? null : new ProgressPlugin({}),
Expand Down
2 changes: 1 addition & 1 deletion lib/core-server/src/__snapshots__/cra-ts-essentials_preview-dev-posix
View file
Open in desktop
Expand Up @@ -473,13 +473,13 @@ Object {
"VirtualModulesPlugin",
"HtmlWebpackPlugin",
"DefinePlugin",
"WatchMissingNodeModulesPlugin",
"HotModuleReplacementPlugin",
"CaseSensitivePathsPlugin",
"ProgressPlugin",
"InterpolateHtmlPlugin",
"ModuleNotFoundPlugin",
"ReactRefreshPlugin",
"WatchMissingNodeModulesPlugin",
"ManifestPlugin",
"IgnorePlugin",
"ForkTsCheckerWebpackPlugin",
Expand Down
1 change: 0 additions & 1 deletion lib/core-server/src/__snapshots__/html-kitchen-sink_preview-dev-posix
View file
Open in desktop
Expand Up @@ -459,7 +459,6 @@ Object {
"VirtualModulesPlugin",
"HtmlWebpackPlugin",
"DefinePlugin",
"WatchMissingNodeModulesPlugin",
"HotModuleReplacementPlugin",
"CaseSensitivePathsPlugin",
"ProgressPlugin",
Expand Down
1 change: 0 additions & 1 deletion lib/core-server/src/__snapshots__/vue-3-cli_preview-dev-posix
View file
Open in desktop
Expand Up @@ -497,7 +497,6 @@ Object {
"VirtualModulesPlugin",
"HtmlWebpackPlugin",
"DefinePlugin",
"WatchMissingNodeModulesPlugin",
"HotModuleReplacementPlugin",
"CaseSensitivePathsPlugin",
"ProgressPlugin",
Expand Down
1 change: 0 additions & 1 deletion lib/core-server/src/__snapshots__/web-components-kitchen-sink_preview-dev-posix
View file
Open in desktop
Expand Up @@ -496,7 +496,6 @@ Object {
"VirtualModulesPlugin",
"HtmlWebpackPlugin",
"DefinePlugin",
"WatchMissingNodeModulesPlugin",
"HotModuleReplacementPlugin",
"CaseSensitivePathsPlugin",
"ProgressPlugin",
Expand Down
91 changes: 1 addition & 90 deletions yarn.lock
View file
Open in desktop
Expand Up @@ -8584,7 +8584,6 @@ __metadata:
"@storybook/ui": 6.5.0-alpha.5
"@types/case-sensitive-paths-webpack-plugin": ^2.1.4
"@types/node": ^14.0.10 || ^16.0.0
"@types/react-dev-utils": ^9.0.4
"@types/terser-webpack-plugin": ^5.0.2
"@types/webpack": ^4.41.26
"@types/webpack-dev-middleware": ^3.7.3
Expand All @@ -8609,7 +8608,6 @@ __metadata:
postcss-flexbugs-fixes: ^4.2.1
postcss-loader: ^4.2.0
raw-loader: ^4.0.2
react-dev-utils: ^11.0.4
stable: ^0.1.8
style-loader: ^1.3.0
terser-webpack-plugin: ^4.2.3
Expand Down Expand Up @@ -8671,7 +8669,6 @@ __metadata:
"@storybook/theming": 6.5.0-alpha.5
"@types/case-sensitive-paths-webpack-plugin": ^2.1.4
"@types/node": ^14.0.10 || ^16.0.0
"@types/react-dev-utils": ^9.0.4
"@types/terser-webpack-plugin": ^5.0.2
"@types/webpack-dev-middleware": ^4.1.0
"@types/webpack-hot-middleware": ^2.25.3
Expand All @@ -8687,7 +8684,6 @@ __metadata:
glob-promise: ^3.4.0
html-webpack-plugin: ^5.0.0
path-browserify: ^1.0.1
react-dev-utils: ^11.0.4
stable: ^0.1.8
style-loader: ^2.0.0
terser-webpack-plugin: ^5.0.3
Expand Down Expand Up @@ -9658,7 +9654,6 @@ __metadata:
global: ^4.4.0
lodash: ^4.17.21
prop-types: ^15.7.2
react-dev-utils: ^11.0.4
react-refresh: ^0.11.0
read-pkg-up: ^7.0.1
regenerator-runtime: ^0.13.7
Expand Down Expand Up @@ -10840,16 +10835,6 @@ __metadata:
languageName: node
linkType: hard

"@types/clean-css@npm:*":
version: 4.2.3
resolution: "@types/clean-css@npm:4.2.3"
dependencies:
"@types/node": "*"
source-map: ^0.6.0
checksum: 922cc60be02326d8b177f0b017975bcf546c94f7ccfab2289662e33a65c8dd78620b90ec2ca9771aaae1e9898f73f0a4bdb5d789b659b5b28000949249e79276
languageName: node
linkType: hard

"@types/color-convert@npm:^2.0.0":
version: 2.0.0
resolution: "@types/color-convert@npm:2.0.0"
Expand Down Expand Up @@ -11090,28 +11075,6 @@ __metadata:
languageName: node
linkType: hard

"@types/html-minifier@npm:*":
version: 4.0.0
resolution: "@types/html-minifier@npm:4.0.0"
dependencies:
"@types/clean-css": "*"
"@types/relateurl": "*"
"@types/uglify-js": "*"
checksum: 21fd26a5285928e7da5c6ad78a12727984ac0d97bfd609bab27f40d90aa615acefc7d34e7f4c367c37ffaf5572e2c65fa0b1479ce2fcc531be2e8fd4520e7bb3
languageName: node
linkType: hard

"@types/html-webpack-plugin@npm:*":
version: 3.2.4
resolution: "@types/html-webpack-plugin@npm:3.2.4"
dependencies:
"@types/html-minifier": "*"
"@types/tapable": "*"
"@types/webpack": "*"
checksum: 7320f7e12217c34b3ebabe831bae054bfe8d011612c7f9777a9ddd1a8c4437b9e9b7431d4984b43a9d5aa5b5b88e29110b7102c4abd3a9c5902d95dc071413f0
languageName: node
linkType: hard

"@types/http-proxy-middleware@npm:*":
version: 0.19.3
resolution: "@types/http-proxy-middleware@npm:0.19.3"
Expand Down Expand Up @@ -11576,19 +11539,6 @@ __metadata:
languageName: node
linkType: hard

"@types/react-dev-utils@npm:^9.0.4":
version: 9.0.4
resolution: "@types/react-dev-utils@npm:9.0.4"
dependencies:
"@types/eslint": "*"
"@types/express": "*"
"@types/html-webpack-plugin": "*"
"@types/webpack": "*"
"@types/webpack-dev-server": "*"
checksum: 3b5e073508bfe48204b78250c82d9fa2eb6f5369afbff378cd6f1749a1d41f2cd66e7f983b4579e07cc81503d11f5b26274215f5c1e640144b90b4de9a2621df
languageName: node
linkType: hard

"@types/react-dom@npm:16.9.10":
version: 16.9.10
resolution: "@types/react-dom@npm:16.9.10"
Expand Down Expand Up @@ -11666,13 +11616,6 @@ __metadata:
languageName: node
linkType: hard

"@types/relateurl@npm:*":
version: 0.2.28
resolution: "@types/relateurl@npm:0.2.28"
checksum: 355727429aa8cd9e3f6cf9baca8bdbd4f1fe521f19938d43f82f5aa673a2b4c9d26a147e420f0690bb51207c4e9ff273d41d83eb7d8cbffdb0a14ddd94f6b6f2
languageName: node
linkType: hard

"@types/resolve@npm:0.0.8":
version: 0.0.8
resolution: "@types/resolve@npm:0.0.8"
Expand Down Expand Up @@ -11920,7 +11863,7 @@ __metadata:
languageName: node
linkType: hard

"@types/webpack-dev-server@npm:*, @types/webpack-dev-server@npm:^3.11.0":
"@types/webpack-dev-server@npm:^3.11.0":
version: 3.11.1
resolution: "@types/webpack-dev-server@npm:3.11.1"
dependencies:
Expand Down Expand Up @@ -39328,38 +39271,6 @@ fsevents@^1.2.7:
languageName: node
linkType: hard

"react-dev-utils@npm:^11.0.4":
version: 11.0.4
resolution: "react-dev-utils@npm:11.0.4"
dependencies:
"@babel/code-frame": 7.10.4
address: 1.1.2
browserslist: 4.14.2
chalk: 2.4.2
cross-spawn: 7.0.3
detect-port-alt: 1.1.6
escape-string-regexp: 2.0.0
filesize: 6.1.0
find-up: 4.1.0
fork-ts-checker-webpack-plugin: 4.1.6
global-modules: 2.0.0
globby: 11.0.1
gzip-size: 5.1.1
immer: 8.0.1
is-root: 2.1.0
loader-utils: 2.0.0
open: ^7.0.2
pkg-up: 3.1.0
prompts: 2.4.0
react-error-overlay: ^6.0.9
recursive-readdir: 2.2.2
shell-quote: 1.7.2
strip-ansi: 6.0.0
text-table: 0.2.0
checksum: 3982f6a35035627b4465c8afd2f6db6a571b9e7b09c7d2f2e517de9cd48bb76778f4c692cdc99a26d2961d7dac371553fd7815ec0d2ec281927feeba60ce8a70
languageName: node
linkType: hard

"react-docgen-typescript-plugin@npm:^0.6.2":
version: 0.6.3
resolution: "react-docgen-typescript-plugin@npm:0.6.3"
Expand Down