Angular: Use ɵReflectionCapabilities to find component & module metadata #17156
+81
−76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI ran the following commands for commit 7d8f3ee. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
the use of '@angular/elements' is no longer necessary for the doc Inline
shilman
requested changes
Jan 7, 2022
There was a problem hiding this comment.
Hi @ThibaudAV -- it looks like this change breaks a few of the snapshot tests in CI. Can you please take a look?
ThibaudAV
force-pushed
the
angular/fix-angular-13.1
branch
from
1af9353 to
7d8f3ee
Compare
|
@shilman done, Very good test 💌 I hadn't thought about this case |
shilman
changed the title
shilman
added
patch:yes
shilman
added a commit
that referenced
this pull request
Jan 29, 2022
Angular: Use ɵReflectionCapabilities to find component & module metadata
This was referenced Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #11613 #14828
Surly several with angular 13 or 12 where the recovery of input / output was important. for exemple
And when the ngOnChanges didn't work.
Link to my comment here : #11613 (comment)
link here too : #14828 (comment)
What I did
As Reflect is no longer used by Angular, it is no longer necessary for storybook to rely on it.
I change storybook to use the
ɵReflectionCapabilitiesfunction of Angular which will allow to have the same behavior as an Angular application to find component MetadataHow to test