Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump cli-table3 to fix colors.js bug in 5.3 #17182

Merged
merged 3 commits into from Jan 10, 2022
Merged

Bump cli-table3 to fix colors.js bug in 5.3 #17182

merged 3 commits into from Jan 10, 2022

Conversation

shilman
Copy link
Member

@shilman shilman commented Jan 10, 2022

Issue: #17179

What I did

For users stuck on 5.3 including react-native users

How to test

N/A

@shilman shilman changed the base branch from next to release/5.3 January 10, 2022 11:25
@shilman shilman changed the title Fix colors.js bug in 5.3 Bump cli-table3 to fix colors.js bug in 5.3 Jan 10, 2022
@flo-sch
Copy link
Contributor

flo-sch commented Jan 10, 2022

Good reactivity, the impact of that one is nasty...
Which SB version range are you guys planning to support?

@shilman shilman merged commit d8784b3 into release/5.3 Jan 10, 2022
@shilman shilman deleted the fix-colorsjs-53 branch January 10, 2022 12:14
@shilman shilman mentioned this pull request Jan 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alterx alterx Awaiting requested review from alterx alterx is a code owner

@igor-dv igor-dv Awaiting requested review from igor-dv igor-dv is a code owner

@tmeasday tmeasday Awaiting requested review from tmeasday tmeasday is a code owner

Assignees
No one assigned
Labels
dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shilman @flo-sch