Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Addon-interactions] Do not rely on global #17680

Closed
wants to merge 1 commit into from
Closed

Conversation

IanVS
Copy link
Member

@IanVS IanVS commented Mar 10, 2022

Issue: #17516

What I did

It seems that #17614 was unintentionally reverted by #17627. This adds it back, with a comment to hopefully catch the eye in the future so it is not changed back again.

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@nx-cloud
Copy link

nx-cloud bot commented Mar 10, 2022

☁️ Nx Cloud Report

CI ran the following commands for commit ced6dc4. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@IanVS
Copy link
Member Author

IanVS commented Mar 10, 2022

This may not actually work anyway. I'm investigating.

@IanVS IanVS marked this pull request as draft March 10, 2022 14:11
@IanVS
Copy link
Member Author

IanVS commented Mar 10, 2022

Yeah, the only reason it was working for me in my own project is that I used patch-package to remove a few lines of jest-mock that cause problems. I'm hopeful that jest might release a fix on their end, but so far it's only in their 28 alpha versions, and that version drops support for node versions that storybook still supports. I've asked if they can push it to a 27 release, but we'll see. I'll need to try to think of another way to solve this in the meantime.

@IanVS IanVS closed this Mar 10, 2022
@stof stof deleted the global-jest-mock branch August 31, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant