-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angular: Do not use default for includePaths #17876
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit eadc4fd. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Nice!!!! :D :D @shilman do you think this modification makes sense? It's been causing some issues on our side! :) |
Hey, @kroeder — Can you take a look at this, please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the PR! 🙂
@kroeder let me know if there is anything to be done with the failing tests. I'm not sure how they could have failed given I didn't touch the areas of the failing tests? (Vue, CRA?) |
I'm not sure actually. I heard yesterday there are issues with the pipeline Anything we can do about the failing steps @ndelangen @shilman? |
@kroeder we're working on those CI failures, which are unrelated to this PR. Merging! Thanks everybody! |
Thanks!! |
Whoohooo!!! :D |
Angular: Do not use default for includePaths
Issue: In Nx Workspaces, the CLI evaluates the
schema.json
file slightly differently to how Angular CLI evaluates it.The Angular CLI will only look at the parent object's default value and return that when the option is not provided.
The Nx CLI will look at the parent object's childrens' default values and build out an object that matches those defaults, as would be expected.
This leads to erroneous behaviors in Nx Workspaces, as the
stylePreprocessorOptions
coming from the app's browser build target will get overridden by an object of the form:What I did
I removed the default empty array form
includePaths
as this is the source of the erroneous behavior. It also does not need to have a default value as it is an optional property.How to test
If your answer is yes to any of these, please make sure to include it in your PR.