Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix jest 27 in angular e2e modern inline rendering config #18274

Merged
merged 1 commit into from
May 19, 2022

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented May 19, 2022

Issue: N/A

What I did

@storybook/test-runner does not work with Jest 28, so I changed the angular e2e config to use 27 instead.

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

Sorry, something went wrong.

@yannbf yannbf added the maintenance User-facing maintenance tasks label May 19, 2022
@nx-cloud
Copy link

nx-cloud bot commented May 19, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 741df67. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@yannbf yannbf added the patch:yes Bugfix & documentation PR that need to be picked to main branch label May 19, 2022
@shilman shilman merged commit fb8acad into next May 19, 2022
@shilman shilman deleted the chore/fix-sb-docs-ci branch May 19, 2022 15:57
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label May 20, 2022
shilman added a commit that referenced this pull request May 20, 2022
chore: fix jest 27 in angular e2e modern inline rendering config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants