Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: add more sandboxes to CI tests #20892

Merged
merged 4 commits into from
Feb 7, 2023
Merged

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Feb 2, 2023

Issue: #20886

What I did

This PR enables sandbox templates which were defined but still under inDevelopment treatment:

  • html-vite js
  • html-vite ts
  • internal storyStoreV6 projects

Some tests were disabled for ssv6 given the lack of support for certain features.

Additionally, I changed the STORYBOOK_TEMPLATE_NAME variable to use the template key instead, which I believe everyone thought it was the key already, however it was using the readable name property.

How to test

  1. CI should test them out and surface any issues (or lack thereof)!

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@yannbf yannbf added build Internal-facing build tooling & test updates ci:daily Run the CI jobs that normally run in the daily job. labels Feb 2, 2023
@yannbf yannbf force-pushed the chore/enable-sandbox-templates branch 3 times, most recently from 53c5a6a to 60d9535 Compare February 3, 2023 15:49
@yannbf
Copy link
Member Author

yannbf commented Feb 3, 2023

@tmeasday @shilman it seems that the e2e to test the ordering of stories fails for ssv6. Is that a bug, should the test be changed or should the test be skipped for ssv6?

@JReinhold
Copy link
Contributor

@tmeasday @shilman it seems that the e2e to test the ordering of stories fails for ssv6. Is that a bug, should the test be changed or should the test be skipped for ssv6?

I did some investigation on this, and I think it's a bug, and the failing test has caught that.

The docs pages in:

I wonder if #18659 is related to this.

@tmeasday
Copy link
Member

tmeasday commented Feb 4, 2023

Sounds like a bug @yannbf! Yay for tests :)

@tmeasday
Copy link
Member

tmeasday commented Feb 4, 2023

@yannbf if you like disable the test and add an issue to fix+enable it?

@yannbf
Copy link
Member Author

yannbf commented Feb 5, 2023

@yannbf if you like disable the test and add an issue to fix+enable it?

Done! Sorry for the poor description: #20941

@yannbf yannbf force-pushed the chore/enable-sandbox-templates branch 4 times, most recently from ae900da to 00ac79e Compare February 6, 2023 09:39
@yannbf yannbf removed the ci:daily Run the CI jobs that normally run in the daily job. label Feb 6, 2023
@yannbf yannbf force-pushed the chore/enable-sandbox-templates branch from 00ac79e to c8aebdb Compare February 6, 2023 10:15
@yannbf yannbf added the ci:merged Run the CI jobs that normally run when merged. label Feb 6, 2023
- html-vite js
- html-vite ts
- qwik-vite
- internal storiesOf projects
- Seems like project.json route is not working, which make metadata fail
- Generated Storybook is not standard, which makes it incompatible with e2e tests
@yannbf yannbf force-pushed the chore/enable-sandbox-templates branch from c8aebdb to 96cf158 Compare February 6, 2023 10:46
@ndelangen ndelangen merged commit fcf0aa8 into next Feb 7, 2023
@ndelangen ndelangen deleted the chore/enable-sandbox-templates branch February 7, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates ci:merged Run the CI jobs that normally run when merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants