Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Svelte/Vite: Prevent crash when no svelte.config file #21339

Merged
merged 3 commits into from
Mar 2, 2023
Merged

Svelte/Vite: Prevent crash when no svelte.config file #21339

merged 3 commits into from
Mar 2, 2023

Commits on Mar 1, 2023

  1. Set svelteConfig to empty object by default. 

    The svelteDocgen plugin crashes Storybook if you have no svelte config file defined. It tries to destructure the options, but with no config file, this value is null, causing a crash. Setting an empty object as a fallback looks like it solved the issue.
    @JustinEloffBBD
    JustinEloffBBD committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    b781dc9 View commit details
    Browse the repository at this point in the history

  2. Fix linting

    @shilman
    shilman committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    198e6f0 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2023

  1. Move the default value into the svelte-docgen plugin.

    @justineloff
    justineloff committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    5f214d0 View commit details
    Browse the repository at this point in the history