Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewport: Remove transitions when switching viewports #21537

Closed
wants to merge 1 commit into from
Closed

Viewport: Remove transitions when switching viewports #21537

wants to merge 1 commit into from

Conversation

jpzwarte
Copy link
Member

As discussed in https://discord.com/channels/486522875931656193/489892645087215636/1075748069016084580 & https://discord.com/channels/486522875931656193/1075807552027230308

This PR removes the width & height transitions when switching between viewports.

@shilman shilman changed the title Remove the transitions when switching viewports. Viewports: Remove transitions when switching viewports Mar 13, 2023
@shilman shilman changed the title Viewports: Remove transitions when switching viewports Viewport: Remove transitions when switching viewports Mar 13, 2023
@ndelangen
Copy link
Member

Thank you for this contribution @jpzwarte !
We'll be merging this right after 7.0 is shipped 👍

@jpzwarte jpzwarte closed this by deleting the head repository Mar 14, 2023
@ndelangen
Copy link
Member

@jpzwarte Why close this PR?

@jpzwarte
Copy link
Member Author

@ndelangen I removed my local fork, which caused this PR to be closed :( Was not my intention.

@jpzwarte
Copy link
Member Author

jpzwarte commented Apr 6, 2023

@ndelangen Created a new PR with the restored branch: #21963

@jpzwarte jpzwarte closed this Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants