Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vite: Unpin rollup version #21748

Merged
merged 1 commit into from Mar 28, 2023
Merged

Vite: Unpin rollup version #21748

merged 1 commit into from Mar 28, 2023

Conversation

IanVS
Copy link
Member

@IanVS IanVS commented Mar 23, 2023

Closes #

What I did

This unpins the version of rollup, which was done in #21723.

The rollup issue was fixed in rollup/rollup#4919.

How to test

CI should pass with the new rollup version.

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@ndelangen ndelangen merged commit eecc0f7 into next Mar 28, 2023
70 checks passed
@ndelangen ndelangen deleted the unpin-rollup branch March 28, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants