-
-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated flags and properties #21852
Changes from all commits
06a39c3
b066110
fb36fd9
ac69c94
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -243,19 +243,6 @@ function preparePartialAnnotations<TRenderer extends Renderer>( | |
initialArgsBeforeEnhancers | ||
); | ||
|
||
// Add some of our metadata into parameters as we used to do this in 6.x and users may be relying on it | ||
|
||
if (!global.FEATURES?.breakingChangesV7) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should this be removed? I wonder if it's needed somehow in case There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is breakingChangesV7 not always There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @yannbf I don't think it's necessarily to do with ssv7, just an old implementation detail that we used to store these things in parameters. We never told people to read them from there (AFAIK), but we were playing it safe in 6.x. I think we can definitely drop this code in 7.0, but we may have missed the boat. Not sure about There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm pretty confident this is just good to merge. We haven't heard anyone at all about this feature flag. We should have removed it prior, but the name is pretty clear in it's intent. |
||
contextForEnhancers.parameters = { | ||
...contextForEnhancers.parameters, | ||
__id: id, | ||
globals: projectAnnotations.globals, | ||
globalTypes: projectAnnotations.globalTypes, | ||
args: contextForEnhancers.initialArgs, | ||
argTypes: contextForEnhancers.argTypes, | ||
}; | ||
} | ||
|
||
const { name, story, ...withoutStoryIdentifiers } = contextForEnhancers; | ||
|
||
return withoutStoryIdentifiers; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This branch never gets executed.