Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#21325) Fix search bar not reflecting custom shortcut when set #21892

Conversation

adityaKrModak
Copy link
Contributor

@adityaKrModak adityaKrModak commented Apr 3, 2023

Closes #21325

What I did

Description:

Fixed the bug by retrieving the latest changes from the context using api.getShortcutKeys().search.
Additionally, there was a text overflow issue which was also addressed by updating the styling.

Changes Made:

Retrieved latest changes from context using api.getShortcutKeys().search
Updated styling to prevent text overflow

Screenshots:

  • Upon testing found the text was overflowing

Pasted Graphic 1

  • Here is the screenshot with the text overflowing fix as well

image

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@adityaKrModak adityaKrModak changed the title Fix search shortcut key on search bar #21325 (#21325) Fix search shortcut key on search bar Apr 3, 2023
@adityaKrModak adityaKrModak changed the title (#21325) Fix search shortcut key on search bar (#21325) Fix search bar shortcut key on search bar Apr 3, 2023
@adityaKrModak adityaKrModak changed the title (#21325) Fix search bar shortcut key on search bar (#21325) Fix search bar not reflecting custom shortcut when set Apr 3, 2023
@kylegach
Copy link
Contributor

Hi, @adityaKrModak! Thank you for this contribution. There is already an open PR with very similar changes here: #21619. Would you mind confirming that those changes also solve the issue? We try to merge the earliest submitted PR for a given bug, so we'll close this one. Thanks again!

@kylegach kylegach closed this Apr 10, 2023
@adityaKrModak
Copy link
Contributor Author

Yes @kylegach ! #21619 solve the same issue. I saw it later that there was already a PR for this bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Searchbar does not reflect custom shortcut if set
3 participants