Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: Remove unsupported frameworks/renderers and improve builder detection #22492

Merged
merged 11 commits into from
May 11, 2023
Merged

CLI: Remove unsupported frameworks/renderers and improve builder detection #22492

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
74f8fce
Remove unsupported/broken frameworks/renderers
valentinpalkovic May 10, 2023
f8b1141
Remove webpack detection and use dependencies to detect the builder a…
valentinpalkovic May 10, 2023
27d81ad
Merge branch 'next' into valentin/fix-could-not-find-framework-renderer
valentinpalkovic May 10, 2023
ff0e2fd
Add more restrictive check for webpack5 builder
valentinpalkovic May 10, 2023
2ce2c21
Remove Svelte and SvelteKit as viable project types for fallback to V…
valentinpalkovic May 10, 2023
d6029e6
Update detectBuilder function to include explicit Webpack 5 builder f…
valentinpalkovic May 10, 2023
61e6299
Merge branch 'next' into valentin/fix-could-not-find-framework-renderer
valentinpalkovic May 10, 2023
22d9eb2
Add webpack.config.js file creation to Vue-CLI and Preact-CLI templat…
valentinpalkovic May 11, 2023
78f25de
Remove defaulting to webpack 5 builder for some project types
valentinpalkovic May 11, 2023
68f4c0a
Merge branch 'next' into valentin/fix-could-not-find-framework-renderer
valentinpalkovic May 11, 2023
d23a7fc
Merge remote-tracking branch 'origin/next' into valentin/fix-could-no…
valentinpalkovic May 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 11 additions & 2 deletions code/lib/cli/src/detect.ts
View file
Open in desktop
Expand Up @@ -128,14 +128,23 @@ export async function detectBuilder(packageManager: JsPackageManager, projectTyp

// Fallback to Vite or Webpack based on project type
switch (projectType) {
case ProjectType.VUE:
case ProjectType.VUE3:
case ProjectType.SFC_VUE:
return CoreBuilder.Vite;
case ProjectType.REACT_SCRIPTS:
valentinpalkovic marked this conversation as resolved.
Show resolved Hide resolved
case ProjectType.ANGULAR:
case ProjectType.NEXTJS:
return CoreBuilder.Webpack5;
/**
* START: Explicit Webpack 5 builder
*
* These project types are explicitly using Webpack 5 if a vite.config file is not found, because
* a vite.config file is necessary to configure these project types to use Vite, which is already
* handled above
*/
case ProjectType.PREACT:
case ProjectType.VUE:
case ProjectType.VUE3:
valentinpalkovic marked this conversation as resolved.
Show resolved Hide resolved
/** END: Explicit Webpack 5 builder */
return CoreBuilder.Webpack5;
default:
// eslint-disable-next-line no-case-declarations
Expand Down