Angular: Fix 16.1 compatibility #23064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndelangen
added
bug
angular
patch:yes
42 tasks
github-actions bot
pushed a commit
that referenced
this pull request
Jun 14, 2023
Bug: Fix for angular 16.1 compatibility (cherry picked from commit 4f0c895)
Merged
69 tasks
github-actions bot
pushed a commit
that referenced
this pull request
Jun 14, 2023
Bug: Fix for angular 16.1 compatibility (cherry picked from commit 4f0c895)
github-actions bot
pushed a commit
that referenced
this pull request
Jun 14, 2023
Bug: Fix for angular 16.1 compatibility (cherry picked from commit 4f0c895)
github-actions bot
pushed a commit
that referenced
this pull request
Jun 14, 2023
Bug: Fix for angular 16.1 compatibility (cherry picked from commit 4f0c895)
github-actions bot
pushed a commit
that referenced
this pull request
Jun 14, 2023
Bug: Fix for angular 16.1 compatibility (cherry picked from commit 4f0c895)
github-actions bot
pushed a commit
that referenced
this pull request
Jun 14, 2023
Bug: Fix for angular 16.1 compatibility (cherry picked from commit 4f0c895)
shilman
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
Jun 14, 2023
Bug: Fix for angular 16.1 compatibility (cherry picked from commit 4f0c895)
github-actions bot
pushed a commit
that referenced
this pull request
Jun 14, 2023
Bug: Fix for angular 16.1 compatibility (cherry picked from commit 4f0c895)
github-actions bot
pushed a commit
that referenced
this pull request
Jun 14, 2023
Bug: Fix for angular 16.1 compatibility (cherry picked from commit 4f0c895)
github-actions bot
pushed a commit
that referenced
this pull request
Jun 14, 2023
Bug: Fix for angular 16.1 compatibility (cherry picked from commit 4f0c895)
github-actions bot
pushed a commit
that referenced
this pull request
Jun 14, 2023
Bug: Fix for angular 16.1 compatibility (cherry picked from commit 4f0c895)
EdricChan03
added a commit
to EdricChan03/material-storybook
that referenced
this pull request
Jun 15, 2023
Also bumps RxJS to 7.x See storybookjs/storybook#23057 and storybookjs/storybook#23064 for more info TODO: Rollback to 7.0.21 when storybookjs/storybook#23012 is merged
JReinhold
added
the
patch:done
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23057
What I did
I found out that angular moved the code internall that we used to replicate their webpack config.
I made it future & backwards compatible with a
try-catchtrying both places.How to test
Sandboxes should pass