CLI: Fix pnp paths logic in storybook metadata #23259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannbf
added
bug
cli
patch:yes
yannbf
force-pushed
the
fix/pnp-paths-logic
branch
from
5427fad
to
4cefbb8
Compare
shilman
approved these changes
Jun 30, 2023
6 tasks
JReinhold
pushed a commit
that referenced
this pull request
Jul 2, 2023
CLI: Fix pnp paths logic in storybook metadata (cherry picked from commit 446bed6)
Merged
15 tasks
github-actions
bot
added
the
patch:done
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23252
What I did
The logic from #23199 was slightly wrong, making the code try to require a package json with a wrong path and therefore break. This PR switches the logic to only parse and remove pnp paths after retrieving the package json for a given storybook framework
How to test
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:mergedorci:dailyGH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]