Next.js: Fix next/image usage in latest Next.js release #23296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentinpalkovic
changed the title
valentinpalkovic
added
bug
nextjs
ci:daily
valentinpalkovic
changed the title
…st Next.js release
valentinpalkovic
force-pushed
the
valentin/fix-next-images-in-latest-release
branch
2 times, most recently
from
d4e9976
to
e14f5f9
Compare
valentinpalkovic
force-pushed
the
valentin/fix-next-images-in-latest-release
branch
from
e14f5f9
to
c16dce1
Compare
4 tasks
valentinpalkovic
added
the
patch:yes
This was referenced Jul 4, 2023
Merged
shilman
pushed a commit
that referenced
this pull request
Jul 4, 2023
…in-latest-release Next.js: Fix next/image usage in latest Next.js release (cherry picked from commit d4a3a23)
shilman
pushed a commit
that referenced
this pull request
Jul 4, 2023
…n-latest-release Next.js: Fix next/image usage in latest Next.js release (cherry picked from commit d4a3a23)
github-actions
bot
added
patch:done
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23287
What I did
It was not possible to override the default component from next/image anymore, because the component was defined via Object.defineProperty to prevent overrides. The override now happens during build time instead of runtime.
How to test
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:mergedorci:dailyGH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]