Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addons: Improve code quality by using title as FC & sharing state via useAddonState #23298

Merged
merged 13 commits into from Jul 6, 2023

Conversation

ndelangen
Copy link
Member

Telescoped off: #23288

What I did

  • refactor the addon/actions to update the title due to it's own state
  • refactor the addon/actions to update the title to use a FC
  • refactor the addon/a11y to update the title to use a FC
  • refactor the addon/controls to update the title to use a FC

How to test

  • Addon actions should function as it was, but with a nicer looking number indicator
  • Addon a11y should function as it was, but with a nicer looking number indicator
  • Addon controls should function as it was, but with a nicer looking number indicator

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@ndelangen ndelangen changed the base branch from release/7.2 to norbert/ui-tabs-types-improvements July 4, 2023 10:29
@ndelangen ndelangen self-assigned this Jul 4, 2023
Base automatically changed from norbert/ui-tabs-types-improvements to release/7.2 July 6, 2023 22:29
@ndelangen ndelangen merged commit 36abf93 into release/7.2 Jul 6, 2023
51 checks passed
@ndelangen ndelangen deleted the norbert/improve-more-addons branch July 6, 2023 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants