Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular: Fix esm issue in combination with rxjs v6 #23405

Merged
merged 1 commit into from Jul 11, 2023

Conversation

valentinpalkovic
Copy link
Contributor

Closes #23324

What I did

Fixed an ESM-specific issue in Angular in combination with rxjs v6

How to test

  • not necessary. I did the tests

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@valentinpalkovic valentinpalkovic self-assigned this Jul 11, 2023
@valentinpalkovic valentinpalkovic added bug angular patch:yes Bugfix & documentation PR that need to be picked to main branch labels Jul 11, 2023
@valentinpalkovic valentinpalkovic force-pushed the valentin/fix-esm-issue-in-angular branch from d8c060e to 4575bcf Compare July 11, 2023 13:44
@valentinpalkovic valentinpalkovic changed the title Fix esm issue in Angular in rxjs v6 Angular: Fix esm issue in combination with rxjs v6 Jul 11, 2023
@valentinpalkovic valentinpalkovic added the ci:daily Run the CI jobs that normally run in the daily job. label Jul 11, 2023
@valentinpalkovic valentinpalkovic merged commit 2535f02 into next Jul 11, 2023
100 of 103 checks passed
@valentinpalkovic valentinpalkovic deleted the valentin/fix-esm-issue-in-angular branch July 11, 2023 14:23
storybook-bot pushed a commit that referenced this pull request Jul 11, 2023
…angular

Angular: Fix esm issue in combination with rxjs v6
(cherry picked from commit 2535f02)
@github-actions github-actions bot mentioned this pull request Jul 11, 2023
9 tasks
storybook-bot pushed a commit that referenced this pull request Jul 11, 2023
…angular

Angular: Fix esm issue in combination with rxjs v6
(cherry picked from commit 2535f02)
@github-actions github-actions bot mentioned this pull request Jul 11, 2023
27 tasks
storybook-bot pushed a commit that referenced this pull request Jul 11, 2023
…angular

Angular: Fix esm issue in combination with rxjs v6
(cherry picked from commit 2535f02)
storybook-bot pushed a commit that referenced this pull request Jul 11, 2023
…angular

Angular: Fix esm issue in combination with rxjs v6
(cherry picked from commit 2535f02)
storybook-bot pushed a commit that referenced this pull request Jul 11, 2023
…angular

Angular: Fix esm issue in combination with rxjs v6
(cherry picked from commit 2535f02)
@github-actions github-actions bot mentioned this pull request Jul 11, 2023
10 tasks
storybook-bot pushed a commit that referenced this pull request Jul 11, 2023
…angular

Angular: Fix esm issue in combination with rxjs v6
(cherry picked from commit 2535f02)
storybook-bot pushed a commit that referenced this pull request Jul 11, 2023
…angular

Angular: Fix esm issue in combination with rxjs v6
(cherry picked from commit 2535f02)
storybook-bot pushed a commit that referenced this pull request Jul 12, 2023
…angular

Angular: Fix esm issue in combination with rxjs v6
(cherry picked from commit 2535f02)
storybook-bot pushed a commit that referenced this pull request Jul 12, 2023
…angular

Angular: Fix esm issue in combination with rxjs v6
(cherry picked from commit 2535f02)
storybook-bot pushed a commit that referenced this pull request Jul 12, 2023
…angular

Angular: Fix esm issue in combination with rxjs v6
(cherry picked from commit 2535f02)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
angular bug ci:daily Run the CI jobs that normally run in the daily job. patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
2 participants