Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript: Added expanded to CoreCommon_StorybookRefs to fix typescript errors #23488

Merged
merged 5 commits into from Jul 25, 2023
Merged

TypeScript: Added expanded to CoreCommon_StorybookRefs to fix typescript errors #23488

merged 5 commits into from Jul 25, 2023

Conversation

DotwoodMedia
Copy link
Contributor

Closes #

What I did

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "build", "documentation", "maintenance", "dependencies", "other"]

Copy link
Contributor

@kasperpeulen kasperpeulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ndelangen ndelangen self-assigned this Jul 24, 2023
@kasperpeulen
Copy link
Contributor

@DotwoodMedia Can you fix the ESlint problem?

@ndelangen ndelangen merged commit 23800ab into storybookjs:next Jul 25, 2023
44 of 49 checks passed
@github-actions github-actions bot mentioned this pull request Jul 25, 2023
27 tasks
@ndelangen ndelangen changed the title Added expanded to CoreCommon_StorybookRefs to fix typescript errors TypeScript: Added expanded to CoreCommon_StorybookRefs to fix typescript errors Jul 26, 2023
@github-actions github-actions bot mentioned this pull request Jul 26, 2023
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants