Angular: Make enableProdMode optional #23489
Merged
+19
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentinpalkovic
added
bug
angular
ci:daily
|
cc @Tallyb |
|
Thanks!!! |
yannbf
reviewed
Jul 19, 2023
valentinpalkovic
deleted the
valentin/make-enable-prod-mode-in-angular-optional
branch
storybook-bot
pushed a commit
that referenced
this pull request
Jul 19, 2023
…mode-in-angular-optional Angular: Make enableProdMode optional (cherry picked from commit 10e38b5)
This was referenced Jul 19, 2023
Merged
storybook-bot
pushed a commit
that referenced
this pull request
Jul 19, 2023
…mode-in-angular-optional Angular: Make enableProdMode optional (cherry picked from commit 10e38b5)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 19, 2023
…mode-in-angular-optional Angular: Make enableProdMode optional (cherry picked from commit 10e38b5)
|
Thanks, looking forward to this, was just hacking a way to disable prod in order to debug some issues I was having. |
|
FWIW - our context is that we use Playwright to test components on top of Storybook. We use the angular debug tool (window.ng) to evaluate some changes in the component. window.ng is only available in dev mode. |
storybook-bot
pushed a commit
that referenced
this pull request
Jul 20, 2023
…mode-in-angular-optional Angular: Make enableProdMode optional (cherry picked from commit 10e38b5)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 20, 2023
…mode-in-angular-optional Angular: Make enableProdMode optional (cherry picked from commit 10e38b5)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 21, 2023
…mode-in-angular-optional Angular: Make enableProdMode optional (cherry picked from commit 10e38b5)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 21, 2023
…mode-in-angular-optional Angular: Make enableProdMode optional (cherry picked from commit 10e38b5)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 21, 2023
…mode-in-angular-optional Angular: Make enableProdMode optional (cherry picked from commit 10e38b5)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 21, 2023
…mode-in-angular-optional Angular: Make enableProdMode optional (cherry picked from commit 10e38b5)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 21, 2023
…mode-in-angular-optional Angular: Make enableProdMode optional (cherry picked from commit 10e38b5)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 21, 2023
…mode-in-angular-optional Angular: Make enableProdMode optional (cherry picked from commit 10e38b5)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 24, 2023
…mode-in-angular-optional Angular: Make enableProdMode optional (cherry picked from commit 10e38b5)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 24, 2023
…mode-in-angular-optional Angular: Make enableProdMode optional (cherry picked from commit 10e38b5)
5 tasks
github-actions
bot
added
the
patch:done
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates #23272
Addresses the following comment: #23404 (comment)
What I did
The enableProdMode is now configurable. It defaults in
devmode tofalseand inbuildmode totrue. The defaults can be overwritten by the options, which are passed to thestorybookandbuild-storybookexecutor in theangular.jsonHow to test
Checklist
MIGRATION.MD
Maintainers
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts["cleanup", "BREAKING CHANGE", "feature request", "bug", "build", "documentation", "maintenance", "dependencies", "other"]