Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: Gracefully shutdown and cleanup execa child processes #23538

Merged
merged 8 commits into from Jul 21, 2023
Merged

CLI: Gracefully shutdown and cleanup execa child processes #23538

merged 8 commits into from Jul 21, 2023

Commits on Jul 20, 2023

  1. Await telemetry init event

    @valentinpalkovic
    valentinpalkovic committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    3b0509f View commit details
    Browse the repository at this point in the history

  2. Gracefully shutdown and cleanup execa child processes 

    Execa child processes should be cleanup up as soon as the parent process quits. During initialization the "cancel" event should properly be sent and it should not lead to error events sent.
    @valentinpalkovic
    valentinpalkovic committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    499346e View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2023

  1. Implement robust solution to not report SIGINT as error

    @valentinpalkovic
    valentinpalkovic committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    fdc8f81 View commit details
    Browse the repository at this point in the history

  2. Cancel process properly inside telemetry HoC

    @valentinpalkovic
    valentinpalkovic committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    bd46163 View commit details
    Browse the repository at this point in the history

  3. Update code/lib/cli/src/initiate.ts

    @yannbf
    yannbf committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    e2231e0 View commit details
    Browse the repository at this point in the history

  4. Fix error handling for execaCommand in JsPackageManager

    @valentinpalkovic
    valentinpalkovic committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    2d3e76a View commit details
    Browse the repository at this point in the history

  5. Merge branch 'next' into valentin/proper-error-handling-and-logging

    @yannbf
    yannbf committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    f1bd18c View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'origin/next' into valentin/proper-error… 

    …-handling-and-logging
    @valentinpalkovic
    valentinpalkovic committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    3e6487d View commit details
    Browse the repository at this point in the history