Core: Fix composeStories typings
#23577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannbf
requested review from
valentinpalkovic,
kasperpeulen,
ndelangen and
tmeasday
as code owners
tmeasday
reviewed
Jul 24, 2023
tmeasday
reviewed
Jul 24, 2023
kasperpeulen
requested changes
Aug 4, 2023
- fix types which were unsound - improve StoriesWithPartialProps type to filter non-story exports
yannbf
force-pushed
the
feat/improved-portable-stories-types
branch
from
9f15aaf
to
bb74e0b
Compare
Merged
8 tasks
kasperpeulen
changed the title
composeStories typingscomposeStories typings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
How to test
No need, this has been tested already, and it's mostly Typescript checking.
You can play around in
code/renderers/react/src/__test__/composeStories.test.tsxfor validationI made changes to type names, please review them and let me know if something doesn't seem good.
Checklist
MIGRATION.MD
Maintainers
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts["cleanup", "BREAKING CHANGE", "feature request", "bug", "build", "documentation", "maintenance", "dependencies", "other"]