Skip empty Vue 3 slot generation #23650
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have this kind of structures in our components:
```
<div v-if="$slots.icon" class="p-4">
<slot name="icon" />
</div>
```
With Storybook 7.1, these broke due to the Vue 3 renderer's updated slot generation.
Previously it used story props to populate Vue component slots, but this was
changed to use argTypes in 6c806b6, after which all stories had all slots defined.
This would cause such conditions as the example above to always be truthy.
This commit modifies the slot generation a bit to allow slots to be undefined
rather than defaulting to an `() => undefined` function value.
aapokiiso
force-pushed
the
vue3-skip-empty-slot-generation
branch
from
e1202a9
to
88ac5c1
Compare
|
I made another PR that should also fix this: |
|
Is fixed in 7.3.0-alpha.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
We have structures like this in our components:
With Storybook 7.1, these broke due to the Vue 3 renderer's updated slot generation. Previously it used story props to populate Vue component slots, but this was changed to use argTypes in 6c806b6, after which all stories had all slots defined. This would cause such conditions as the example above to always be truthy.
This commit modifies the slot generation a bit to allow slots to be undefined rather than defaulting to an
() => undefinedfunction value.How to test
yarn task --task sandbox --start-from auto --template vue3-vite/default-tsExample/Buttonstory and verify that the icon wrapper<span>does not exist on the button stories with noiconslot value defined.Checklist
MIGRATION.MD
Maintainers
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts["cleanup", "BREAKING CHANGE", "feature request", "bug", "build", "documentation", "maintenance", "dependencies", "other"]🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>