Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channels: Remove self-referencing in package.json #23681

Merged
merged 2 commits into from Aug 2, 2023
Merged

Conversation

stof
Copy link
Contributor

@stof stof commented Aug 2, 2023

this looks like a mistake when merging channels in #23032

What I did

I removed the self-referencing dependency.

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "build", "documentation", "maintenance", "dependencies", "other"]

馃 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@stof stof changed the title Remove self-referencing dependency Core: Remove self-referencing dependency Aug 2, 2023
@ndelangen ndelangen self-assigned this Aug 2, 2023
@ndelangen ndelangen added maintenance User-facing maintenance tasks ci:normal patch:no and removed dependencies labels Aug 2, 2023
@ndelangen ndelangen changed the title Core: Remove self-referencing dependency Channels: Remove self-referencing in package.json Aug 2, 2023
@ndelangen ndelangen merged commit aad2749 into next Aug 2, 2023
53 checks passed
@ndelangen ndelangen deleted the stof-patch-1 branch August 2, 2023 14:01
@github-actions github-actions bot mentioned this pull request Aug 2, 2023
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:normal maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants