Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Fix ArgsTable empty state on docs #23688

Merged
merged 7 commits into from Aug 3, 2023
Merged

Conversation

cdedreuille
Copy link
Contributor

@cdedreuille cdedreuille commented Aug 2, 2023

What I did

After updating the ArgsTable to have a better loading state and empty state, we forgot that the empty state was also used in docs. This PR address that.

This is how it looks right now 馃憞

CleanShot 2023-08-02 at 16 31 23@2x

This is how it look with this PR 馃憞

CleanShot 2023-08-03 at 08 00 52@2x

How to test

  1. Run Storybook UI locally with yarn storybook:ui on this branch
  2. Open this story -> http://localhost:6006/?path=/story/blocks-blocks-docspage--single-story
  3. Look at the empty state in docs

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "build", "documentation", "maintenance", "dependencies", "other"]

馃 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@cdedreuille cdedreuille added ui maintenance User-facing maintenance tasks ci:normal patch:no labels Aug 2, 2023
@cdedreuille cdedreuille marked this pull request as ready for review August 2, 2023 15:13
@JReinhold JReinhold merged commit 6d11b07 into next Aug 3, 2023
47 of 53 checks passed
@JReinhold JReinhold deleted the charles-fix-empty-state-docs branch August 3, 2023 10:43
@github-actions github-actions bot mentioned this pull request Aug 3, 2023
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:normal maintenance User-facing maintenance tasks ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants