Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Fix error logging being swallowed from dev/build failures #23689

Merged
merged 1 commit into from Aug 2, 2023

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Aug 2, 2023

Closes #

What I did

This PR fixes a bug that was introduced in #23182 where error logs would be swallowed:

image

How to test

  1. Run a sandbox for template, e.g. yarn task --task sandbox --start-from auto --template react-webpack/18-ts
  2. Ovewrite webpackFinal with an error, e.g.:
  webpackFinal: async (config) => {
    config.module.rules = []
    return config;
  },
  1. Run Storybook, check the error message

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "build", "documentation", "maintenance", "dependencies", "other"]

馃 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@yannbf yannbf added bug cli patch:yes Bugfix & documentation PR that need to be picked to main branch labels Aug 2, 2023
@yannbf yannbf merged commit 708a084 into next Aug 2, 2023
59 of 67 checks passed
@yannbf yannbf deleted the yann/fix-error-logging branch August 2, 2023 16:56
This was referenced Aug 2, 2023
JReinhold pushed a commit that referenced this pull request Aug 2, 2023
CLI: Fix error logging being swallowed from dev/build failures
(cherry picked from commit 708a084)
@JReinhold JReinhold mentioned this pull request Aug 2, 2023
5 tasks
@github-actions github-actions bot mentioned this pull request Aug 3, 2023
32 tasks
@kasperpeulen kasperpeulen removed the patch:yes Bugfix & documentation PR that need to be picked to main branch label Aug 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

Fails
馃毇

PR is not labeled with one of: ["patch:no","patch:yes"]

Generated by 馃毇 dangerJS against b6a486d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants