Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue3: Don't map undefined slots #23713

Closed
wants to merge 2 commits into from
Closed

Conversation

chakAs3
Copy link
Contributor

@chakAs3 chakAs3 commented Aug 3, 2023

Closes #23668,

What I did

I return undefined or null if the slots undefined or null, in the slots mapping function

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "build", "documentation", "maintenance", "dependencies", "other"]

馃 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@chakAs3 chakAs3 added bug vue3 ci:daily Run the CI jobs that normally run in the daily job. labels Aug 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

Fails
馃毇

PR is not labeled with one of: ["patch:no","patch:yes"]

Generated by 馃毇 dangerJS against 3a7f2c4

@storybook-bot
Copy link
Contributor

Failed to publish canary version of this pull request, triggered by @chakAs3. See the failed workflow run at: https://github.com/storybookjs/storybook/actions/runs/5754725581

@ndelangen
Copy link
Member

This PR is likely a duplicate of #23697 @kasperpeulen @chakAs3

I'll close this one, but feel free to re-open if that's incorrect. 馃檹

@ndelangen ndelangen closed this Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ci:daily Run the CI jobs that normally run in the daily job. vue3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Storybook 7.1 broke Vue slots (slots are never undefined)
3 participants