Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Update postinstall to look for addon script #23791

Merged
merged 2 commits into from Aug 11, 2023
Merged

Conversation

ShaunEvening
Copy link
Contributor

What I did

Updated postinstallAddon to look for a postinstall file in the addon that they just installed via storybook add

How to test

  • Locally build the CLI
  • Create fresh storybook project with webpack
  • run node ../path/to/local/cli add @storybook/addon-styling@1.3.7--canary.82.252d20c.0

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "build", "documentation", "maintenance", "dependencies", "other"]

馃 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@ShaunEvening ShaunEvening added cli ci:merged Run the CI jobs that normally run when merged. labels Aug 10, 2023
@ShaunEvening ShaunEvening changed the title (CLI): Update postinstall to look for addon script CLI: Update postinstall to look for addon script Aug 10, 2023
@ShaunEvening ShaunEvening added the maintenance User-facing maintenance tasks label Aug 10, 2023
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for one bit

code/lib/cli/src/add.ts Outdated Show resolved Hide resolved
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@shilman shilman merged commit 19d26cc into next Aug 11, 2023
69 of 71 checks passed
@shilman shilman deleted the shaun/new-add-cmd branch August 11, 2023 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:merged Run the CI jobs that normally run when merged. cli maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants