Addons: Deprecate key in addon render function as it is not available anymore #23792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasperpeulen
added a commit
to storybookjs/addon-designs
that referenced
this pull request
Aug 10, 2023
ndelangen
approved these changes
Aug 10, 2023
kasperpeulen
requested review from
JReinhold,
cdedreuille and
tmeasday
as code owners
9 tasks
AvremelM
added a commit
to AvremelM/storybook-design-token
that referenced
this pull request
Oct 24, 2023
reyronald
added a commit
to reyronald/storybook-formik
that referenced
this pull request
Jan 9, 2024
reyronald
added a commit
to reyronald/storybook
that referenced
this pull request
Jan 9, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23782
What I did
Addons: Deprecate key in addon render function as it is not available anymore
How to test
See that you get a deprecation warning when you try to use
key.Checklist
MIGRATION.MD
Maintainers
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts["cleanup", "BREAKING CHANGE", "feature request", "bug", "build", "documentation", "maintenance", "dependencies", "other"]馃 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>