Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Update IconButton and add new Toolbar component #23795

Merged
merged 2 commits into from Aug 11, 2023

Conversation

cdedreuille
Copy link
Contributor

What I did

In this PR we are improving the IconButton component to allow for animated icons. We are also adding a new Toolbar component that's essentially a wrapper on top of Radix Toolbar. This will allow us to improve accessibility and keyboard navigation on the toolbar going forward.

How to test

  1. Run this branch locally using yarn storybook:ui
  2. Open Storybook in your browser at this link http://localhost:6006/?path=/story/core-ui-toolbar--base
  3. You should now see the new Toolbar component

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "build", "documentation", "maintenance", "dependencies", "other"]

馃 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@cdedreuille cdedreuille added maintenance User-facing maintenance tasks ci:normal labels Aug 10, 2023
@cdedreuille cdedreuille self-assigned this Aug 10, 2023
@socket-security
Copy link

New dependencies detected. Learn more about Socket for GitHub 鈫楋笌

Packages Version New capabilities Transitives Size Publisher
@radix-ui/react-toolbar 1.0.4 None +8 438 kB benoitgrelard

@cdedreuille cdedreuille marked this pull request as ready for review August 10, 2023 15:31
Copy link
Contributor

@kasperpeulen kasperpeulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cdedreuille cdedreuille merged commit ae80dc4 into next Aug 11, 2023
58 of 64 checks passed
@cdedreuille cdedreuille deleted the charles-ui-updates branch August 11, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:normal maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants