Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Support Chrome 100, Safari 15 and Firefox 91 #23800

Merged
merged 2 commits into from Aug 11, 2023

Conversation

kasperpeulen
Copy link
Contributor

Closes #23564

What I did

Pin esbuild to 0.18.0, which transpiles static properties in a way that Safari can handle

How to test

Check that code/lib/manager-api/dist/index.mjs doesn't contain:

  static {
    this.displayName = "Manager";
  }

But is transpiled now to ManagerProvider.displayName = "Manager"

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "build", "documentation", "maintenance", "dependencies", "other"]

馃 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@kasperpeulen kasperpeulen added bug maintenance User-facing maintenance tasks labels Aug 11, 2023
@shilman shilman changed the title Esbuild: Fix storybuild not working in safari Esbuild: Fix support for older versions of Safari Aug 11, 2023
@shilman shilman added patch:yes Bugfix & documentation PR that need to be picked to main branch ci:normal and removed maintenance User-facing maintenance tasks labels Aug 11, 2023
@kasperpeulen kasperpeulen merged commit 8d8fc73 into next Aug 11, 2023
16 of 18 checks passed
@kasperpeulen kasperpeulen deleted the kasper/fix-safari-static branch August 11, 2023 09:44
@kasperpeulen kasperpeulen changed the title Esbuild: Fix support for older versions of Safari Esbuild: Set browser target to chrome100, safari15 and firefox91 Aug 11, 2023
@kasperpeulen kasperpeulen changed the title Esbuild: Set browser target to chrome100, safari15 and firefox91 Build: Support Chrome 100, Safari 15 and Firefox 91 Aug 11, 2023
storybook-bot pushed a commit that referenced this pull request Aug 11, 2023
Esbuild: Fix support for older versions of Safari
(cherry picked from commit 8d8fc73)
@github-actions github-actions bot mentioned this pull request Aug 11, 2023
3 tasks
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ci:normal patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Storybook in Safari not working
2 participants